Welcome! » Log In » Create A New Profile

Patch: Run preexec and postexec before rotating higher inter

Posted by Anonymous 
Patch: Run preexec and postexec before rotating higher inter
April 14, 2011 07:01AM
Hi All,

I use the preexec hook to setup (mostly mount) my backup media, so I need it to
be run for every rsnapshot action, including ones that are just rotation. I've
attached a patch which does that. I don't know if this is a change you want to
make in the main version or not -- it would be good for me, but bad for people
who do expensive operations in preexec.

-Eric

--
Eric W. Anderson Electrical and Computer Engineering
andersoe < at > ece.cmu.edu Carnegie Mellon University
phone: +1-412-268-1908 Hamerschlag A311

PGP key fingerprint:
D3C5 D6FF EDED 9F1F C36D 53A3 74B7 53A6 3C74 5F12

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
rsnapshot-discuss mailing list
rsnapshot-discuss < at > lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rsnapshot-discuss
Patch: Run preexec and postexec before rotating higher inter
April 14, 2011 07:26AM
On Thu, 2011-04-14 at 09:34 -0400, Eric W. Anderson wrote:
[quote]I use the preexec hook to setup (mostly mount) my backup media, so I need it to
be run for every rsnapshot action, including ones that are just rotation. I've
attached a patch which does that. I don't know if this is a change you want to
make in the main version or not -- it would be good for me, but bad for people
who do expensive operations in preexec.
[/quote]
The current pre/postexec is for preparing the sources for a snapshot to
be captured, e.g., putting servers in read-only mode. Setting up access
to the snapshot root would be a different feature. See
https://sourceforge.net/tracker/?func=detail&aid=2446248&group_id=88546&atid=587079 .

--
Matt

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
rsnapshot-discuss mailing list
rsnapshot-discuss < at > lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rsnapshot-discuss
Patch: Run preexec and postexec before rotating higher inter
April 14, 2011 08:10AM
Thus spake Matt McCutchen (matt < at > mattmccutchen.net):

...

[quote]The current pre/postexec is for preparing the sources for a snapshot to
be captured, e.g., putting servers in read-only mode. Setting up access
to the snapshot root would be a different feature. See
https://sourceforge.net/tracker/?func=detail&aid=2446248&group_id=88546&atid=587079 .
[/quote]
I'll buy that. Do you think such a feature should be implemented? You suggest
a wrapper in your sourceforge comment. My inclination would be to put it in
rsnapshot itself, just because a wrapper would be one more thing for the user
to keep track of, but that's not a very powerful argument.

-Eric

--
Eric W. Anderson Electrical and Computer Engineering
andersoe < at > ece.cmu.edu Carnegie Mellon University
phone: +1-412-268-1908 Hamerschlag A311

PGP key fingerprint:
D3C5 D6FF EDED 9F1F C36D 53A3 74B7 53A6 3C74 5F12

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
rsnapshot-discuss mailing list
rsnapshot-discuss < at > lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rsnapshot-discuss
Sorry, only registered users may post in this forum.

Click here to login