Backup Central

Hi,

I'm currently using BackupPC 2.0.2 with cygwin rsyncd to perform backups of
Windows hosts.

Using the BackupPC_Admin interface, if I click on the host on the left hand
side, then click on one of the "Errors" hyperlinks under "Xfer Error
Summary", taking me to
http://servername/cgi-bin/BackupPC_Admin?action=view&type=XferErr&num=5&host=hostname

I see the log in its entireity, and it's very hard to pick out the errors by
eye.

I've identified the part of the admin cgi which strips out the non-error
lines, and added in 7 more regexps which appear to filter out the necessary
non-error lines, to keep the errors preserved. I've included a diff -u of
the relevant section below.
Can anyone see any problems with the change I've made? Is it likely to strip
out any errors by accident?

[I've had a quick look at the 2.1.0beta0 module and this section of code
looks the same, although I haven't tried executing it. Apologies if I'm
asking about something which has already been changed]

Thankyou very much to all the developers, I think BackupPC is an excellent
piece of software.
Peter

----------------------------------------------------------------------------
----------------------------

--- backuppcdistribution/BackupPC-2.0.2/cgi-bin/BackupPC_Admin
2003-10-07 07:55:49.000000000 +0100
+++ /var/www/cgi-bin/BackupPC_Admin 2004-04-14 12:45:08.000000000 +0100
< at > < at > -435,6 +435,13 < at > < at >
last;
}
if ( /smb: \\>/
+ || /^\s*create d / #following 7
lines added by pgl
+ || /^\s*pool /
+ || /^\s*create /
+ || /^\s*same /
+ || /^\s*delete /
+ || /^\s*delete d /
+ || /^\s*pool l /
|| /^\s*(\d+) \(\s*\d+\.\d kb\/s\) (.*)$/
|| /^tar: dumped \d+ files/
|| /^\s*added interface/i




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
BackupPC-users mailing list
BackupPC-users < at > lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/backuppc-users
http://backuppc.sourceforge.net/

"Peter Lloyd" writes:

I'm currently using BackupPC 2.0.2 with cygwin rsyncd to perform backups of
Windows hosts.

Using the BackupPC_Admin interface, if I click on the host on the left hand
side, then click on one of the "Errors" hyperlinks under "Xfer Error
Summary", taking me to
http://servername/cgi-bin/BackupPC_Admin?action=view&type=XferErr&num=5&host=hostname

I see the log in its entireity, and it's very hard to pick out the errors by
eye.

The major issue is a typo in BackupPC_Admin where it is ignoring
lines that start with 3 spaces rather then 2. It's a one character
fix, also include in 2.1.0beta0.

I've identified the part of the admin cgi which strips out the non-error
lines, and added in 7 more regexps which appear to filter out the necessary
non-error lines, to keep the errors preserved. I've included a diff -u of
the relevant section below.

The patch wasn't included in your email. Could you resend?
I'm happy to check it out, but I believe the correct fix is
to ignore lines that start with two spaces, rather than 3.

Craig


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
BackupPC-users mailing list
BackupPC-users < at > lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/backuppc-users
http://backuppc.sourceforge.net/

The major issue is a typo in BackupPC_Admin where it is ignoring
lines that start with 3 spaces rather then 2. It's a one character
fix, also include in 2.1.0beta0.

Such a subtle change, thanks!
I've applied that to my copy and it's sorted the problem, definately the
most elegant solution.

I'll hopefully have the chance to upgrade to 2.1.0beta0 in a few weeks.

The patch wasn't included in your email. Could you resend?
I'm happy to check it out, but I believe the correct fix is
to ignore lines that start with two spaces, rather than 3.

This is what I included in the original email:

--- BackupPC-2.0.2/cgi-bin/BackupPC_Admin 2003-10-07 07:55:49.000000000
+0100
+++ /var/www/cgi-bin/BackupPC_Admin 2004-04-14 12:45:08.000000000 +0100
< at > < at > -435,6 +435,13 < at > < at >
last;
}
if ( /smb: \\>/
+ || /^\s*create d /
+ || /^\s*pool /
+ || /^\s*create /
+ || /^\s*same /
+ || /^\s*delete /
+ || /^\s*delete d /
+ || /^\s*pool l /
|| /^\s*(\d+) \(\s*\d+\.\d kb\/s\) (.*)$/
|| /^tar: dumped \d+ files/
|| /^\s*added interface/i


Thankyou very much
Peter