Backup Central

"David Kempe" <dave < at > solutionsfirst.com.au>
wrote the following on Tue, 6 Jan 2004 13:01:33 +1100

Hi I am attempting to do a restore on a cygwin rdiff-backup install.
I am getting the fs_ablities.py failing on creating a folder. I
assume the foo file is a test of some sort, I appears to fail with
OS error 22 instead of just disabling that part of the test. Is
there some sort of patch we can try to disable this testing? the
testing is very useful, but needs this tweak for it to restore on
windows.

Hi, hopefully we can just fix the bugs in the testing, not disable
it. The following patch may fix two of your problems:

--- fs_abilities.py.old 2004-01-27 18:12:56.000000000 -0800
+++ fs_abilities.py 2004-01-27 18:14:28.000000000 -0800
< at > < at > -187,7 +187,7 < at > < at >
tmp_rp.chown(uid+1, gid+1) # just choose random uid/gid
tmp_rp.chown(0, 0)
except (IOError, OSError), exc:
- if exc[0] == errno.EPERM:
+ if exc[0] in (errno.EPERM, errno.EINVAL):
log.Log("Warning: ownership cannot be changed on filesystem "
"at %s" % (self.root_rp.path,), 3)
self.ownership = 0
< at > < at > -202,7 +202,8 < at > < at >
hl_source.touch()
try:
hl_dest.hardlink(hl_source.path)
- assert hl_source.getinode() == hl_dest.getinode()
+ if hl_source.getinode() != hl_dest.getinode():
+ raise IOError(errno.EOPNOTSUP, "Hard links don't compare")
except (IOError, OSError), exc:
if exc[0] in (errno.EOPNOTSUPP, errno.EPERM):
log.Log("Warning: hard linking not supported by filesystem "


--
Ben Escoto

Ben Escoto wrote:
Hi, hopefully we can just fix the bugs in the testing, not disable
it. The following patch may fix two of your problems:

Hi Ben,
message from Woody one of my developers:

-------

I have corrected the patch below: :-)

It is EOPNOTSUPP, not EOPNOTSUP

Cheers,
Woody

--- fs_abilities.py.old 2004-01-27 18:12:56.000000000 -0800
+++ fs_abilities.py 2004-01-27 18:14:28.000000000 -0800
< at > < at > -187,7 +187,7 < at > < at >
tmp_rp.chown(uid+1, gid+1) # just choose random
uid/gid tmp_rp.chown(0, 0)
except (IOError, OSError), exc:
- if exc[0] == errno.EPERM:
+ if exc[0] in (errno.EPERM, errno.EINVAL):
log.Log("Warning: ownership cannot be
changed on filesystem "
"at %s" %
(self.root_rp.path,), 3)
self.ownership = 0
< at > < at > -202,7 +202,8 < at > < at >
hl_source.touch()
try:
hl_dest.hardlink(hl_source.path)
- assert hl_source.getinode() == hl_dest.getinode()
+ if hl_source.getinode() != hl_dest.getinode():
+ raise IOError(errno.EOPNOTSUPP, "Hard links
don't compare")
except (IOError, OSError), exc:
if exc[0] in (errno.EOPNOTSUPP, errno.EPERM):
log.Log("Warning: hard linking not
supported by filesystem "

---------------

I think the wrapping broke it.
Anyway, its only a one letter fix.

After applying that patch filesystem detection didn't break anymore, so
thats great. However now it runs and just stop complaining it can't find
a current mirror marker. I can't make it spit out anymore errors than
that - it fs detection works, then it just says destination invalid,
can't find current mirror.
The rdiff-backup-data dir is created and there is a log file and
quoted.chars in there but no current mirror.
Is current mirror created at the begining or end of the backup?
we are testing by backing up win32 -> win32 local to local.
I think restores would work tho.
I will get back to you after testing

dave

David Kempe <dave < at > solutionsfirst.com.au>
wrote the following on Thu, 29 Jan 2004 21:15:47 +1100

I have corrected the patch below: :-)

It is EOPNOTSUPP, not EOPNOTSUP

Thanks, your correction is committed.

After applying that patch filesystem detection didn't break anymore, so
thats great. However now it runs and just stop complaining it can't find
a current mirror marker. I can't make it spit out anymore errors than
that - it fs detection works, then it just says destination invalid,
can't find current mirror.
The rdiff-backup-data dir is created and there is a log file and
quoted.chars in there but no current mirror.
Is current mirror created at the begining or end of the backup?
we are testing by backing up win32 -> win32 local to local.
I think restores would work tho.
I will get back to you after testing

I think you describe this error in another message; will eventually look
at that if so.


--
Ben Escoto