Backup Central

Hi, first let me thank you for picking back up the developement of this
AWESOME tool!

However, I'm having an issue..

I use rdiff-backup to back up my systems (duh).. well, I nightly do a
'--remove-older-than 30D' followed by a fetch of the new data.

I have been using 0.12.6 since I started doing backups.. then when I had
this problem I came to the www site and was pleasently amazed that
version 1 was released yesterday.

So it's been going for a long time now. Today I needed to do a restore
(using 0.12.6) and got this error... Then I upgraded to 1.0.0 and tried
the restore again and the same thing is still happening.

Any ideas? Is it perhaps caused by something 0.12.6 put in to the
backup data, but wouldn't be a problem from now on?

The following is the output from v1.0.0:

Sending back exception 'filetype' of type exceptions.KeyError:
File "/usr/lib/python2.3/site-packages/rdiff_backup/connection.py",
line 334, in answer_request
result = apply(eval(request.function_string), argument_list)
File "/usr/lib/python2.3/site-packages/rdiff_backup/restore.py", line
317, in patch
ITR(diff.index, diff)
File "/usr/lib/python2.3/site-packages/rdiff_backup/rorpiter.py", line
279, in __call__
last_branch.fast_process(*args)
File "/usr/lib/python2.3/site-packages/rdiff_backup/restore.py", line
633, in fast_process
self.patch_to_temp(rp, diff_rorp, tf)
File "/usr/lib/python2.3/site-packages/rdiff_backup/restore.py", line
640, in patch_to_temp
elif diff_rorp.get_attached_filetype() == 'snapshot':
File "/usr/lib/python2.3/site-packages/rdiff_backup/rpath.py", line
555, in get_attached_filetype
return self.data['filetype']

Davy Durham <pubaddr2 < at > davyandbeth.com>
wrote the following on Mon, 15 Aug 2005 16:31:31 -0500

So it's been going for a long time now. Today I needed to do a restore
(using 0.12.6) and got this error... Then I upgraded to 1.0.0 and tried
the restore again and the same thing is still happening.

Any ideas? Is it perhaps caused by something 0.12.6 put in to the
backup data, but wouldn't be a problem from now on?
...

Sending back exception 'filetype' of type exceptions.KeyError:
...
File "/usr/lib/python2.3/site-packages/rdiff_backup/rpath.py", line
555, in get_attached_filetype
return self.data['filetype']

Hmm I think this may be a bug in rdiff-backup instead of a problem
with your data. Could I see the error with more verbosity so I can
tell what file it's happening to?

Also have you tried restoring different files/directories? Which get
that error and which don't?


--
Ben Escoto

Davy Durham <pubaddr2 < at > davyandbeth.com>
wrote the following on Mon, 15 Aug 2005 16:31:31 -0500

The following is the output from v1.0.0:

Sending back exception 'filetype' of type exceptions.KeyError:
...
return self.data['filetype']

Thanks for the demo script! Hopefully

http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/backup.py.diff?r2=1.30&r1=1.29&diff_format=u

will fix the basic problem, but won't help restore backups that
already have the unsynced mirror_metadata dir problem. For that I
think these two will work:

http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/rorpiter.py.diff?r2=1.27&r1=1.26&diff_format=u
http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/rpath.py.diff?r2=1.84&r1=1.83&diff_format=u


--
Ben Escoto

AH MY BAD! Ignore the previous message..

The patches DID fix the problem.. I just didn't apply them on both machines.

I'm still doing some testing.. will report back.


Also, still two questions:

1) Is it okay/wise to delete the backup.log and restore.log files from
the rdiff-backup-data directories?

2) I'm noticing some old empty directory trees within
rdiff-backup-data/increments that I would presume should have been
removed as the --remove-older-than flag has been being used all along to
produce a rolling 30 day window. These trees have other empty
directories in them... but no files of any kind. Is this normal/expected?

Thanks,
Davy

Ben Escoto wrote:

Davy Durham <pubaddr2 < at > davyandbeth.com>
wrote the following on Mon, 15 Aug 2005 16:31:31 -0500


The following is the output from v1.0.0:

Sending back exception 'filetype' of type exceptions.KeyError:


...


return self.data['filetype']



Thanks for the demo script! Hopefully

http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/backup.py.diff?r2=1.30&r1=1.29&diff_format=u

will fix the basic problem, but won't help restore backups that
already have the unsynced mirror_metadata dir problem. For that I
think these two will work:

http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/rorpiter.py.diff?r2=1.27&r1=1.26&diff_format=u
http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/rpath.py.diff?r2=1.84&r1=1.83&diff_format=u

Okay, I've applied the patches and I do still get an error while
restoring. Are you suggesting that if I do another backup with these
patches in place, *then* I should be able to restore from the newest
backup copy?

I am going to test that scenario anyway..

Thanks again,
Davy


Ben Escoto wrote:

Davy Durham <pubaddr2 < at > davyandbeth.com>
wrote the following on Mon, 15 Aug 2005 16:31:31 -0500


The following is the output from v1.0.0:

Sending back exception 'filetype' of type exceptions.KeyError:


...


return self.data['filetype']



Thanks for the demo script! Hopefully

http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/backup.py.diff?r2=1.30&r1=1.29&diff_format=u

will fix the basic problem, but won't help restore backups that
already have the unsynced mirror_metadata dir problem. For that I
think these two will work:

http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/rorpiter.py.diff?r2=1.27&r1=1.26&diff_format=u
http://savannah.nongnu.org/cgi-bin/viewcvs/rdiff-backup/rdiff-backup/rdiff_backup/rpath.py.diff?r2=1.84&r1=1.83&diff_format=u

Davy Durham <pubaddr2 < at > davyandbeth.com>
wrote the following on Wed, 17 Aug 2005 01:51:27 -0500

Also, still two questions:

1) Is it okay/wise to delete the backup.log and restore.log files from
the rdiff-backup-data directories?

Sure, they are never read by the program.

2) I'm noticing some old empty directory trees within
rdiff-backup-data/increments that I would presume should have been
removed as the --remove-older-than flag has been being used all along to
produce a rolling 30 day window. These trees have other empty
directories in them... but no files of any kind. Is this normal/expected?

Yes, that's normal, but probably should be considered a bug (we might
as well delete those to reduce clutter). I added the issue to the bug
tracker.


--
Ben Escoto

Ben Escoto wrote:

Davy Durham <pubaddr2 < at > davyandbeth.com>
wrote the following on Wed, 17 Aug 2005 01:51:27 -0500





Also, still two questions:

1) Is it okay/wise to delete the backup.log and restore.log files from
the rdiff-backup-data directories?



Sure, they are never read by the program.



cool

2) I'm noticing some old empty directory trees within
rdiff-backup-data/increments that I would presume should have been
removed as the --remove-older-than flag has been being used all along to
produce a rolling 30 day window. These trees have other empty
directories in them... but no files of any kind. Is this normal/expected?



Yes, that's normal, but probably should be considered a bug (we might
as well delete those to reduce clutter). I added the issue to the bug
tracker.



ok great..

BTW- when do you think those patches you created might be in a release?

Davy Durham <pubaddr2 < at > davyandbeth.com>
wrote the following on Wed, 17 Aug 2005 23:28:38 -0500

BTW- when do you think those patches you created might be in a release?

They'll be in 1.0.1, but I don't know when exactly that will get
released.


--
Ben Escoto