On 6/18/07, David Cantrell <david < at > cantrell.org.uk ([email]david < at > cantrell.org.uk[/email])> wrote: On Sun, May 27, 2007 at 01:05:16PM +1000, Michael Ashley wrote:
backup root < at > mymachine.edu:/ mymachine/ rsync_long_args=-f "- *.fits?"
-f "- *.FITS?" -f "- *.bz2" -f "- *.gz" --max-size=64M
So the bug is still there. Slightly differently. The error is now:
Unknown filter rule: `"- *.fits?"'
rsync error: syntax or usage error (code 1) at exclude.c(759)
It goes away with my "join" fix.
Passing a scalar to system() makes my paranoid security senses go
"ping!" because it means that the command is handed to the shell for
argument parsing. Normally you don't want to do that because someone
could "poison" the command so that it (eg) ended with ';rm -rf /'. I'm
pretty sure we're safe in this case though, mostly because *everything*
that's getting passed to system() is coming from the rsnapshot.conf
file, which you do all of course keep nice n secure. Don't you.
I'll apply this fix unless anyone screams horribly.
It's my understanding that system() will escape the arguments to the shell, unlike using backticks.
--
Anthony Ettinger
Ph: 408-656-2473
var (bonita, farley) = new Dog;
farley.barks("very loud");
bonita.barks("at strangers");
http://chovy.dyndns.org/resume.html
http://utuxia.com/consulting
